Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdowns do not scroll on small screen sizes #7937

Open
4 tasks
charlag opened this issue Nov 14, 2024 · 0 comments · May be fixed by #7940
Open
4 tasks

Dropdowns do not scroll on small screen sizes #7937

charlag opened this issue Nov 14, 2024 · 0 comments · May be fixed by #7940
Assignees
@charlag
Labels
bug broken functionality, usability problems, unexpected errors

Comments

@charlag
Copy link
Contributor

charlag commented Nov 14, 2024 •
edited
Loading

When the dropdown does not fill vertically on the screen it is not possible to scroll it to see all the options.

Test notes

  • Reproduce the issue on the small screen
  • Check that dropdown is scrollable if there's not enough space on the side of dropdown (as opposed to overall height like in the issue description)
  • Check that dropdown is not scrollable when all items fit
  • Check that filtering dropdowns works correctly still

Spent: 1h
@charlag charlag added the bug broken functionality, usability problems, unexpected errors label Nov 14, 2024
@charlag charlag self-assigned this Nov 14, 2024
charlag added a commit that referenced this issue Nov 14, 2024
@charlag
Fix dropdown not scrolling when there's not enough vertical space
b471050 
The inner dropdown container was overflowing the outer one instead of
scrolling because its height was not restricted. This could be
reproduced on a screen that's not tall enough e.g. small mobile
screen or landscape orientation of the phone.

Now we set the height to the one of the parent to always have correct
height.

CLose #7937
@charlag charlag linked a pull request Nov 14, 2024 that will close this issue
Open
charlag added a commit that referenced this issue Nov 14, 2024
@charlag
Fix dropdown not scrolling when there's not enough vertical space
69d5d8f 
The inner dropdown container was overflowing the outer one instead of
scrolling because its height was not restricted. This could be
reproduced on a screen that's not tall enough e.g. small mobile
screen or landscape orientation of the phone.

Now we set the height to the one of the parent to always have correct
height.

Close #7937
@charlag charlag linked a pull request Nov 14, 2024 that will close this issue
Fix dropdown not scrolling when there's not enough vertical space #7940
Open
charlag added a commit that referenced this issue Nov 15, 2024
@charlag
Fix dropdown not scrolling when there's not enough vertical space
099a16c 
The inner dropdown container was overflowing the outer one instead of
scrolling because its height was not restricted. This could be
reproduced on a screen that's not tall enough e.g. small mobile
screen or landscape orientation of the phone.

Now we set the height to the one of the parent to always have correct
height.

Close #7937
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charlag charlag

Labels
bug broken functionality, usability problems, unexpected errors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix dropdown not scrolling when there's not enough vertical space tutao/tutanota
1 participant
@charlag