Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor]: create more types to simplify TuonoConfig management #384

Open
marcalexiei opened this issue Jan 20, 2025 · 1 comment
Open
Assignees
Labels
enhancement New feature or request typescript Requires typescript knowledge

Comments

@marcalexiei
Copy link
Member

Probably tuono/config should export type for the options with all required fields to avoid calling many utility types.
E.g.:

interface TuonoConfigServer {
    host: string
     port: number
}

so the config will became something like:

export interface TuonoConfig {
   server?: Partial<TuonoConfigServer>,
  // ...
}

and this will become:

  server: TuonoConfigServer

Tip

I can do this in a separate PR

Originally posted by @marcalexiei in #366 (comment)

@marcalexiei marcalexiei changed the title Create more types to simplify TuonoConfigManagement [Refactor]: create more types to simplify TuonoConfig management Jan 20, 2025
@marcalexiei marcalexiei self-assigned this Jan 20, 2025
@marcalexiei marcalexiei added enhancement New feature or request typescript Requires typescript knowledge labels Jan 20, 2025
@marcalexiei marcalexiei moved this to Ready in Road to V1 Jan 20, 2025
@marcalexiei

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request typescript Requires typescript knowledge
Projects
Status: Ready
Development

No branches or pull requests

1 participant