Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

live: use a different product ID than 0x0001 #86

Open
bentiss opened this issue Feb 13, 2018 · 2 comments
Open

live: use a different product ID than 0x0001 #86

bentiss opened this issue Feb 13, 2018 · 2 comments

Comments

@bentiss
Copy link
Collaborator

bentiss commented Feb 13, 2018

This seems to be wrong

@bentiss bentiss mentioned this issue Feb 13, 2018
7 tasks
@whot whot changed the title live: use a different PID than 0x0001 live: use a different product ID than 0x0001 Feb 14, 2018
@whot
Copy link
Contributor

whot commented Feb 15, 2018

I wonder what the effects are of using the actual PID for this device, at least on the intuos pro. We'd have to send a different stylus ID through though

@bentiss
Copy link
Collaborator Author

bentiss commented Feb 15, 2018

For the Intuos Pro, it could be OK, though we are using a Bluetooth connection and not a USB one. So theoretically, nothing prevents Wacom to reuse this PID in a different Bluetooth product. However, given that Wacom is now using the report descriptors in Linux, we should be fine reusing any PID which doesn't have a special treatment in the wacom.ko module.

The only problem with 0001 is that if we keep the same PID for all versions, libwacom might be confused. Ideally, we should assign one PID per product, or make libwacom matching on something else.

@whot whot added the live mode label Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants