REDIS_CONNECTION example works, unless you don't have redis server running

[str11ngfello]

I've been using tsed.io's ioredis intergration for almost a year. The docs say to do this:

And then you can inject in your other code like this:

As long as you have a redis server running of course.

However, recently I created a tsed cli command to generate types (found that in another dicussion here) and that command passes in a blank object for redis like so:

All this was fine, as long as redis is running. But the cli command just generates types so when I run it in an environment without redis the command repeated trys to connect to redis :D

I Think it's because the way the sample code works for REDIS_CONNECTION provide. It looks like the ioredis Redis object will start a connection just by instantiating it.

How can I modify the sample REDIS_CONNECTION provider to be smart enough to know that I firing up a command and it should not let iosredis try to connect. I saw ioredis has a "lazyConnect" option but am unsure how to use that with this code:

I hope I'm close but just missing something. Anyone have any ideas?

[str11ngfello]

btw, the cli command doesn't finish and repeatedly waits for redis to connect. This is why it's a blocker. If it weren't a hang it might be okay with me. But it's blocking the command from running. Of course I can fire up a local redis docker container and get by, but my CI environment won't have a redis server to connect so it'll fail in that case.

[Romakita]

Hello @str11ngfello

It's a bit strange because when the ioredis options is [], nothing should be initialized. And I confirm that works, because I already had this issue on my own project (Generate types and custom commands).

I also a more complex scenario, because, some custom commands needs redis connection and for the command to generates types isn't necessary.

Here is my code for the CLI:

CliCore.bootstrap({
  ...configuration,
  mongoose: mongooseConfig,
  cache: cacheConfig,
  ioredis: redisConfig, // I let DB configuration because sometime I need it.
  issuers,
  server: Server,
  logstash: false,
  httpClient: {
    transformOperationId(operationId: string, routeNameInfo: any, raw: any) {
      return raw.moduleName === "oidc" ? routeNameInfo.original.replace("oidc", "") : operationId;
    }
  },
  // add your custom commands here
  commands: [GenerateHttpClientCmd, DeprecatedRoutesCmd, ProductCalendarsCmd, StatusPageCmd],
  configResolvers: [databaseResolver] // I provide a configuration Resolver to manage when I need db or not.
})

Here is the databaseResolver:

export function databaseResolver(settings: Record<string, any>) {
  if (!get(settings, "command.enableFeatures").includes("database")) {
    settings.mongoose = [];
    settings.ioredis = [];
    settings.cache = false;
  }
}

Using this snippet, I can now add a metadata on Command decorator to know if the command needs some extra features to works:

@Command({
  name: "calendar",
  description: "Generate the calendars data",
  options: {
   
  },
  enableFeatures: ["database"],
  bindLogger: false
})
export class ProductCalendarsCmd implements CommandProvider { }

You can try that, but for me your actual code should works as expected (while ioredis option is empty).

You can take a look on the code here:
https://github.com/tsedio/tsed/blob/production/packages/orm/ioredis/src/utils/registerConnectionProvider.ts

If your goal is to generate source code from the swagger.json you already have a cli module for that: "@tsed/cli-generate-http-client":
https://github.com/tsedio/tsed-cli/blob/master/packages/cli-generate-http-client/src/commands/GenerateHttpClientCmd.ts

The code example in the discussion is probably obsolete ;)

See you
Romain