Random - DB - Things 👍

[helio-frota]

• Apparently something is printing a binary
  RUST_LOG=debug cargo test -- ingest_sboms --nocapture
  

• I've changed all the tests to let db = Database::for_test("a").await?; and it works 👍
  
  

UPDATE: #141 (comment) we have a risk when running tests in parallel

• I don't know the best place to use this

let mut pg_dump = PgDumpBuilder::from(postgresql.settings())
    .schema_only()
    .file("out.sql")
    .build();
let (_stdout, _stderr) = pg_dump.execute()?;

• Currently db.dump() makes no sense, as best-place-to-use because db is seaORM DBConnection related

  • _:

  #[derive(Clone, Debug)]
  pub struct Database {
      pub db: DatabaseConnection,  <-----
      db_strategy: Arc<DbStrategy>,
  } 

• warning: if we add this line let pg_clone = postgresql.clone(); then is enough to get this:
  

• Related to the dump usage (I'm not 100% sure) probably we will need something like:

#[tokio::test]
    async fn package_version_not_affected_assertions() -> Result<(), anyhow::Error> {
        let db = Database::for_test("a").await?;
        let system = Graph::new(db);

        // things doing things here...

        assert_eq!(assertions.assertions.len(), 1);

        foo.dump() < ---- call dump here ----

        Ok(())
    }

[helio-frota]

I've changed all the tests to let db = Database::for_test("a").await?; and it works

I don't know the reason, maybe it could be simplified ? 🤷

Database::for_test().await?;

[helio-frota]

Makes no sense to call dump for each test [?]

is PM Mode the best place to have a db dump ?

[jcrossley3]

I don't view them as related, no. I would expect an out.sql file to only be of interest to a developer.

[helio-frota]

Fully agree with the interest part 👍

extra context --> Currently [since we are creating multiple databases (using different database names)] we are going to end up with multiple file dumps, instead of one dump-file. That is why I mentioned the PM mode. 👍

[jcrossley3]

What triggers the dump?

[helio-frota]

this block of code:

let mut pg_dump = PgDumpBuilder::from(postgresql.settings())
    .schema_only()
    .file("out.sql")
    .build();
let (_stdout, _stderr) = pg_dump.execute()?;

• We need to find a good way to get the postgresql.settings()
• We need to call that after the boostrap part 👍
• We need to update the dependency and add a new one

postgresql_embedded = { workspace = true, features = ["blocking", "bundled", "tokio"] }
postgresql_commands = { workspace = true }

[helio-frota]

thanks, we have this issue now
#139