Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move term adding function to the install #58

Open
almasaeed2010 opened this issue Mar 8, 2019 · 3 comments
Open

Move term adding function to the install #58

almasaeed2010 opened this issue Mar 8, 2019 · 3 comments

Comments

@almasaeed2010
Copy link
Contributor

We currently generate the term insertion code in the .fields.inc file but the badges guideline specifically asks for this to be in the install file. Would a simple comment suffice? Or do we need to create a new file for it?

@bradfordcondon
Copy link
Member

bradfordcondon commented Mar 8, 2019 via email

@almasaeed2010
Copy link
Contributor Author

@almasaeed2010
Copy link
Contributor Author

It makes sense to add them in the install file since we don't want all fields to attempt to add their terms again with every time cache is cleared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants