Autocomplete: Enable clear icon for multiple selection #3131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
✅ Deploy Preview for moduswebcomponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
@prashanthr6383 When "disabled" is set to true, the clear icon becomes visible and is operable through tab navigation.
Fixed now. Please check |
| @@ -504,6 +515,10 @@ export class ModusAutocomplete { | |||
|
|
|||
| render(): unknown { | |||
| const classes = `autocomplete ${this.classBySize.get(this.size)}`; | |||
| const iconSize = this.size === 'large' ? '24' : '16'; | |||
There was a problem hiding this comment.
The icon sizes used here are standard sizes correct ? Can we have it common across all sizes we use for the icons so that we can maintain the same across places its been used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
References
Fixes #3107
Type of change
How Has This Been Tested?
Checklist