Skip to content
This repository has been archived by the owner on Dec 11, 2023. It is now read-only.

Create a redis backed broker in tmctl #87

Open
sebgoa opened this issue Oct 19, 2022 · 4 comments
Open

Create a redis backed broker in tmctl #87

sebgoa opened this issue Oct 19, 2022 · 4 comments

Comments

@sebgoa
Copy link
Member

sebgoa commented Oct 19, 2022

When we create a broker we should be able to create a redis backed broker.

The redis cluster could be:

  1. running locally in docker
  2. running remotely

It could be done either via a config file of the CLI or via parameters when we create a broker

tmctl create broker --help
TriggerMesh broker

Usage:
  tmctl create broker <name> [flags]

Flags:
  -h, --help   help for broker

Global Flags:
      --broker string    Default broker name
      --version string   TriggerMesh components version (default "v1.21.1")

when the broker is backed by redis, the dump should create an object that uses the new triggermesh broker

I am assigning to Pablo

@jmcx jmcx changed the title Create a redis backed broker Create a redis backed broker in tmctl Nov 14, 2022
@sebgoa sebgoa added the size: S label Jan 9, 2023
@sebgoa
Copy link
Member Author

sebgoa commented Jan 9, 2023

Right now we can set parameters for the memory backed broker in config.yaml:

context: do
triggermesh:
    broker:
        image: gcr.io/triggermesh/memory-broker:latest
        memory:
            buffer-size: "100"
            produce-timeout: 1s
    version: v1.22.0

We should be able to have the same for the redis backed broker, something like:

context: do
triggermesh:
    broker:
        image: gcr.io/triggermesh/redis-broker:latest
       args:
            address:
            username:
            password:
            tls-enabled: (optional)
            skip-verify: (optional)
    version: v1.22.0

@odacremolbap
Copy link
Member

odacremolbap commented Jan 9, 2023

Note: I will be changing very soon the time formats from go durations to ISO8601 duration.

reference: triggermesh/brokers#65

@tzununbekov
Copy link
Member

With #227 merged, CLI config supports a redis-based broker:

context: bar
triggermesh:
    version: v1.23.0
    broker:
        version: v1.1.0
        redis:
            address: 127.0.0.1:6666
            username: foo
            password: bar
            skip-verify: true
            tls-enabled: true

Broker's image attribute is hidden in favor of the version tag to avoid situations when the image is pointing to the in-memory broker and start attributes are defined for redis, or wise-versa.

@tzununbekov tzununbekov removed their assignment Jan 23, 2023
@jmcx
Copy link

jmcx commented May 25, 2023

It should be possible now to use the redis broker locally by manually editing the tmctl config file to look like the above example.

However, we haven't yet documented how the user should do this.

Not a top priority right now but lets keep the issue open as a P2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants