Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/proc/stat hierarchy is not being parsed correctly anymore (regression) #889

Closed
squell opened this issue Oct 21, 2024 · 2 comments · Fixed by #890
Closed

/proc/stat hierarchy is not being parsed correctly anymore (regression) #889

squell opened this issue Oct 21, 2024 · 2 comments · Fixed by #890
Assignees
@squell
Labels
bug Something isn't working C-operatingsystem Low-level glue layers security This issue has security impact (e.g. allows something it should not)

Comments

@squell
Copy link
Member

squell commented Oct 21, 2024 •
edited
Loading

After the merger of #887 (which passed the CI while being 'up to date' with main, which is now the rule since the merge queue was disabled), CI on main seems to be consistently failing.

Two possibilities:

  • This can be related to whatever Couple of small changes #887 touched (timestamping seems implicated), and we may have observed a "flaky success"?
  • We have made the CI more flaky by removing all the caching.
@squell squell added bug Something isn't working non-compliant used to track failing compliance tests CI Meta-issues related to CI investigate Information is needed labels Oct 21, 2024
@squell
Copy link
Member Author

squell commented Oct 21, 2024

So it's not consistently the same test that fail, but I do see a pattern that they are time-stamp related (although sometimes a signal test fails as well). That might be due to poor performance of the CI.

@squell squell changed the title We have a failing compliance test on main? CI is more flaky than usual? Oct 21, 2024
@squell squell added C-operatingsystem Low-level glue layers and removed bug Something isn't working investigate Information is needed non-compliant used to track failing compliance tests CI Meta-issues related to CI labels Oct 21, 2024
@squell
Copy link
Member Author

squell commented Oct 21, 2024

Found the culprit: PR #887 completely broke the delicate /proc/stat parser we had.

@squell squell changed the title CI is more flaky than usual? /proc/stat hierarchy is not being parsed correctly anymore (regression) Oct 21, 2024
@squell squell self-assigned this Oct 21, 2024
@squell squell added bug Something isn't working security This issue has security impact (e.g. allows something it should not) labels Oct 21, 2024
@squell squell linked a pull request Oct 21, 2024 that will close this issue
Fix breakage introduced by #887 #890
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@squell squell

Labels
bug Something isn't working C-operatingsystem Low-level glue layers security This issue has security impact (e.g. allows something it should not)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix breakage introduced by #887 trifectatechfoundation/sudo-rs
1 participant
@squell