Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pending transactions should show date #8719

Closed
komret opened this issue Jun 16, 2023 · 4 comments
Closed

Pending transactions should show date #8719

komret opened this issue Jun 16, 2023 · 4 comments
Labels
transactions Transaction history page

Comments

@komret
Copy link
Contributor

komret commented Jun 16, 2023 •
edited
Loading

image (1)

The above transaction made me confused as it looks like it has been sent this morning. In fact, it has been pending for two weeks, but one cannot tell without opening the detail.

This could be resolved by grouping the the pending transactions same as the rest of history, with date on top.

Suggested look:
Screenshot 2024-05-07 at 18 24 15
@komret komret added the design needed Development is blocked by lack of design label Jun 16, 2023
@komret komret changed the title Pending transaction should show date instead of time if they are more than 24h old Pending transactions should show date instead of time if they are more than 24h old Jun 16, 2023
@Hermez-cz Hermez-cz added low hanging fruit Simple, quick task. Doable in 2 hours. and removed design needed Development is blocked by lack of design labels Jun 19, 2023
@Hermez-cz Hermez-cz self-assigned this Jun 19, 2023
@dahaca
Copy link
Contributor

dahaca commented Jun 20, 2023

I was already working on this, so we can just group Pending TXs by date just like we group normal ones if they are not from today

@szymonlesisz
Copy link
Contributor

there is definetelly something wrong with date/time in pending txs. check out those screenshots

Screenshot from 2023-06-22 11-57-15

Screenshot from 2023-06-22 12-02-01

@hynek-jina hynek-jina added bug Something isn't working as expected coinjoin Related to coinjoin feature labels Jun 22, 2023
@szymonlesisz szymonlesisz mentioned this issue Jul 28, 2023
Merged
@matejkriz matejkriz removed the low hanging fruit Simple, quick task. Doable in 2 hours. label Oct 4, 2023
@komret komret changed the title Pending transactions should show date instead of time if they are more than 24h old Pending transactions should show date Apr 19, 2024
@komret komret added transactions Transaction history page and removed coinjoin Related to coinjoin feature bug Something isn't working as expected labels Apr 19, 2024
@komret
Copy link
Contributor Author

komret commented Jul 31, 2024

Resolved by #12975

QA: To be tested on both mobile and desktop. Please test all types of coins, not just bitcoin-like.

@komret komret closed this as completed Jul 31, 2024
@bosomt
Copy link
Contributor

bosomt commented Aug 6, 2024

QA OK

I can see transaction date in pending transaction. Date differed, probably mobile app uses different bloxk explorer

Image

Image

Image

Image

Info:

  • Suite version: web 24.8.0 (90b029d)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:128.0) Gecko/20100101 Firefox/128.0
  • OS: MacIntel
  • Screen: 1915x1244
  • Device: Trezor T2T1 2.7.2 regular (revision da75d8f4b67410b40a9cfd2954d183d81dd6e8e8)
  • Transport: BridgeTransport 2.0.32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
transactions Transaction history page
Projects
Issues Suite
Archived in project
Milestone
No milestone
Development

No branches or pull requests
7 participants
@szymonlesisz @matejkriz @hynek-jina @bosomt @komret @dahaca @Hermez-cz