Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown can render outside of viewport #12939

Open
AdamSchinzel opened this issue Jun 18, 2024 · 1 comment · May be fixed by #16481
Open

Dropdown can render outside of viewport #12939

AdamSchinzel opened this issue Jun 18, 2024 · 1 comment · May be fixed by #16481
Assignees
@izmy
Labels
bug Something isn't working as expected

Comments

@AdamSchinzel
Copy link
Contributor

Describe the bug
If user opens a dropdown on for example a mobile viewport it can render outside of the viewport and doesn't adjust its position based on the viewport.

How to reproduce
Steps to reproduce the behavior:

  1. Go to some ETH account with 3 or more tokens
  2. Go to tokens tabs
  3. Resize window to mobile viewport
  4. Click on tree dots

Expected behavior
It renders inside viewport so if there isn't a space on the bottom it renders to the top.

Screenshots
Screenshot 2024-06-18 at 10 45 03 AM
@AdamSchinzel AdamSchinzel added the bug Something isn't working as expected label Jun 18, 2024
@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Desktop Jun 18, 2024
@AdamSchinzel
Copy link
Contributor Author

Original issue here - #12860

@tomasklim tomasklim mentioned this issue Nov 24, 2024
Closed
@izmy izmy linked a pull request Jan 20, 2025 that will close this issue
Open
@tomasklim tomasklim moved this from 🎯 To do to 🔎 Needs review in Suite Desktop Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@izmy izmy

Labels
bug Something isn't working as expected
Projects
Suite Desktop
Status: 🔎 Needs review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Popover component for floating content next to a target element trezor/trezor-suite
2 participants
@izmy @AdamSchinzel