Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(trade): buy input decimals #15283

Merged
merged 1 commit into from
Nov 7, 2024
Merged

fix(trade): buy input decimals #15283

merged 1 commit into from
Nov 7, 2024

Conversation

adderpositive
Copy link
Contributor

@adderpositive adderpositive commented Nov 6, 2024 •
edited
Loading

Description

Fixed passing value to input in buy.

Related Issue

Resolve #15284

Screenshots

Before

image

After

image

@adderpositive adderpositive added bug Something isn't working as expected +Invity Related to Invity project labels Nov 6, 2024
@adderpositive adderpositive self-assigned this Nov 6, 2024
@tomasklim tomasklim added the release Will be included in the upcoming release. Needs to be backported to the release branch. label Nov 6, 2024
LukasRada
LukasRada reviewed Nov 7, 2024
View reviewed changes
Copy link
Contributor

@LukasRada LukasRada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check other places where getCoinmarketNetworkDecimals is called with sendCryptoSelect and decide wheter it should be modified similarly or not.

@adderpositive
Copy link
Contributor Author

Please check other places where getCoinmarketNetworkDecimals is called with sendCryptoSelect and decide wheter it should be modified similarly or not.

In other places, it has been already handled.

@tomasklim tomasklim merged commit e7a7dfa into develop Nov 7, 2024
22 checks passed
@tomasklim tomasklim deleted the fix/buy-decimals branch November 7, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasklim tomasklim tomasklim approved these changes

@LukasRada LukasRada LukasRada approved these changes

Assignees

@adderpositive adderpositive

Labels
bug Something isn't working as expected +Invity Related to Invity project release Will be included in the upcoming release. Needs to be backported to the release branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trading - decimals not working in input in buy section
3 participants
@adderpositive @LukasRada @tomasklim