Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Information about account missing when sending ETH. #3536

Closed
obrusvit opened this issue Feb 15, 2024 · 3 comments · Fixed by #4175 · May be fixed by #4471
Closed

Information about account missing when sending ETH. #3536

obrusvit opened this issue Feb 15, 2024 · 3 comments · Fixed by #4175 · May be fixed by #4471
Assignees
@ibz
Labels
altcoin Any non-Bitcoin coins bug Something isn't working as expected

Comments

@obrusvit
Copy link
Contributor

obrusvit commented Feb 15, 2024 •
edited
Loading

Sending flow of ETH and potentially other altcoins does not show the information about the account as is shown in bitcoin sending flow.

Sending BTC shows info about account:
image
Equivalent information is not found when sending e.g. ETH.

The problem was discovered while working on #3517, where similar screens were a part of the design: https://www.figma.com/file/PNqL15hf98oIFjLc0WCrvz/Sandbox-%E2%80%A2-Model-T?type=design&node-id=47-1280&mode=design&t=ApnCXlRR331Frs2h-4
@obrusvit obrusvit added altcoin Any non-Bitcoin coins bug Something isn't working as expected labels Feb 15, 2024
@Hannsek Hannsek added this to Firmware Feb 16, 2024
@Hannsek Hannsek moved this to 🎯 To do in Firmware Feb 16, 2024
@Hannsek
Copy link
Contributor

Hannsek commented Sep 9, 2024

@ibz is this done in your eth PR?

@ibz
Copy link
Contributor

ibz commented Sep 12, 2024

No. I'll have a look at it now.

@ibz ibz mentioned this issue Sep 12, 2024
Merged
@ibz ibz closed this as completed in #4175 Sep 24, 2024
@bosomt bosomt moved this from 🎯 To do to 🤝 Needs QA in Firmware Sep 24, 2024
@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Firmware Oct 10, 2024
@bosomt
Copy link

bosomt commented Oct 10, 2024

QA OK

Info:

  • Suite version: desktop 24.11.0 (850d7ee26ec9c8274058f60bbaba0cc4c29de357)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuiteDev/24.11.0 Chrome/128.0.6613.162 Electron/32.1.2 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.4 regular (revision d71d9e9)
  • Transport: BridgeTransport 2.0.33

@ibz ibz linked a pull request Jan 21, 2025 that will close this issue
feat(core): show ETH account info on model T #4471
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibz ibz

Labels
altcoin Any non-Bitcoin coins bug Something isn't working as expected
Projects
Firmware
Archived in project
Milestone
No milestone
4 participants
@ibz @obrusvit @bosomt @Hannsek