Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic to remove outliers #25

Open
himynamesdave opened this issue Nov 15, 2023 · 5 comments
Open

Add logic to remove outliers #25

himynamesdave opened this issue Nov 15, 2023 · 5 comments
Labels
backlog enhancement New feature or request

Comments

@himynamesdave
Copy link
Member

himynamesdave commented Nov 15, 2023

In some cases, GPS data is erroneous. e.g. the distance or speed between two consecutive points by time is clearly to fast (e.g. 10000 km/h speed)

There are many ways to get rid of outlying points like this:

https://gis.stackexchange.com/questions/19683/what-algorithm-should-i-use-to-remove-outliers-in-trace-data

User should be able to set an outlier "speed" in all modes

--outlier_speed_meters_sec

Default if not passed is 40 meters / second (144 km/h).

When user passes this flag, they can enter any whole number

When a destination photo has a speed greater than the specified outlier speed it will be removed (and logged) from the input photos considered to produce a video (similar logic to when photos in input have no GPS: https://github.com/trek-view/gopro2gsv#validation).

Is dependant on change #26 as this will mean videos are now first processed to images, at which point, outliers can be removed.

@fqrious
Copy link
Contributor

fqrious commented Nov 19, 2023

How is speed calculated?

@himynamesdave
Copy link
Member Author

@fqrious here is an explanation (and implementation)

https://github.com/trek-view/gopro2frames/blob/main/docs/LOGIC.md#gps_speed_meters_second_next

Essentially you use the gps points between consecutive photos to calculate distance and time which will give you speed

@himynamesdave
Copy link
Member Author

closing, will raise individual tickets to cover

@himynamesdave
Copy link
Member Author

This needs more thought. Reopening, can tackle later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants