Use github service containers instead of docker compose #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nopcoder
commented
Oct 15, 2023
•
nopcoder
commented
- replace lakectl setup with lakefs installation env vars
- remove unused repo creation with s3 storage namespace
- removed docker-compose to spin lakefs service. using container service.
- use curl user/password instead of format basic auth
- setup lakefs using env - no need to maintain another docker-compose for lakefs - use curl basic auth (consider replace with lakectl)
nopcoder
force-pushed
the
chore/provider-workflow
branch
from
7ffd6fa
to
b8fd258
Compare
nopcoder
changed the title
arielshaqed
approved these changes
Oct 17, 2023
| - name: lakeFS logs | ||
| if: ${{ always() }} | ||
| run: docker-compose -f ops/docker-compose.yaml logs --tail=1000 lakefs | ||
| command: docker exec lakefs ls lakefs/data/block/data/symlinks/example-repo/example-branch/path/to/symlink.txt |
There was a problem hiding this comment.
I think this loses the logs? Or does GitHub keep them for the service container?
There was a problem hiding this comment.
GitHub dump the services logs at the end as part of the post processing, ex: https://github.com/treeverse/airflow-provider-lakeFS/actions/runs/6533424810/job/17738585733?pr=82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.