Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all source files to use uintN_t #2

Open
ghost opened this issue May 5, 2014 · 1 comment
Open

Update all source files to use uintN_t #2

ghost opened this issue May 5, 2014 · 1 comment

Comments

@ghost
Copy link

ghost commented May 5, 2014

The data types used in goodfet files are of 3 kinds:

-stdint ones (uint8_t, etc)
-normal C ones (unsigned char, etc)
-some more (u8, etc)

My proposition is to use stdint types in every file.

Is there anything unknown to me that would prevent doing that?

@ghost ghost added enhancement labels May 5, 2014
@ghost ghost self-assigned this May 5, 2014
@travisgoodspeed
Copy link
Owner

Nothing prevents it, but be very careful not to damage any code that you don't have the hardware to test. One mistaken regex could break support for a rare module, and it wouldn't be noticed for months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant