BLACK_MINES_KEY is not correctly stashed when removed from shulker

[4Ply]

No description provided.

[4Ply]

Trade log looks fine:

[17:23:09 INFO]: Rule: Convert { type=practice, sourceType=CROWN, sourceCount=2, targetTypes=CAVES_OF_CARNAGE_KEYx1,CAVES_OF_CARNAGE_KEYx1,CAVES_OF_CARNAGE_KEYx1,BLACK_MINES_KEYx1,BLACK_MINES_KEYx1,BLACK_MINES_KEYx1,BURNING_DARK_KEYx1,BURNING_DARK_KEYx1)
[17:23:09 INFO]: Target types: [CAVES_OF_CARNAGE_KEYx1, CAVES_OF_CARNAGE_KEYx1, CAVES_OF_CARNAGE_KEYx1, BLACK_MINES_KEYx1, BLACK_MINES_KEYx1, BLACK_MINES_KEYx1, BURNING_DARK_KEYx1, BURNING_DARK_KEYx1]
[17:23:09 INFO]: Selected target type: BURNING_DARK_KEYx1 (match check: true)
[17:23:09 INFO]: Target type is an dungeon item: BURNING_DARK_KEY
[17:23:09 INFO]: Repeating trade? - false
[17:23:09 INFO]: Could not remove [ItemStack{IRON_NUGGET x 2, UNSPECIFIC_META:{meta-type=UNSPECIFIC, display-name={"color":"green","text":"❄☠ Decked Out Crown (Practice) ☠❄"}, custom-model-data=2, internal=H4sIAAAAAAAA/+NiYOBgYC8pSkxJ9UxhYHUO8g/342BgS0lNzgbymQoMGQACno0BIgAAAA==}}] from shop inventory, reverting
[17:23:09 INFO]: Rule: Convert { type=competitive, sourceType=CROWN, sourceCount=2, targetTypes=CAVES_OF_CARNAGE_KEYx1,CAVES_OF_CARNAGE_KEYx1,CAVES_OF_CARNAGE_KEYx1,BLACK_MINES_KEYx1,BLACK_MINES_KEYx1,BLACK_MINES_KEYx1,BURNING_DARK_KEYx1,BURNING_DARK_KEYx1)
[17:23:09 INFO]: Target types: [CAVES_OF_CARNAGE_KEYx1, CAVES_OF_CARNAGE_KEYx1, CAVES_OF_CARNAGE_KEYx1, BLACK_MINES_KEYx1, BLACK_MINES_KEYx1, BLACK_MINES_KEYx1, BURNING_DARK_KEYx1, BURNING_DARK_KEYx1]
[17:23:09 INFO]: Selected target type: BURNING_DARK_KEYx1 (match check: true)
[17:23:09 INFO]: Target type is an dungeon item: BURNING_DARK_KEY
[17:23:09 INFO]: Repeating trade? - false
[17:23:09 INFO]: Successfully removed 2xCROWN from trade view, submitting trade
[17:23:09 INFO]: Adding 1x BURNING_DARK_KEY (item) to Hixx27's deck
[17:23:09 INFO]: Trade succeeded, refreshing inventory

[4Ply]

So far nothing in the logs looks unusual for their inventory actions. I've asked the player to send me a video the next time they move cards around + queue + get the bug.

I've tried to reproduce it myself, but so far it's working fine :(

[4Ply]

Oh, this may be an issue with ghost keys. Specifically, if a key is consumed in the dungeon but was somehow still in the player's inventory in the lobby, then the key will still remain in their inventory when they reconnect.

This is because citadel does not remove items/cards from the player's inventory if they are removed from the deck. Fixing that should reduce the chances of this bug.