-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
control ↔ exec の API を追加 #195
base: develop
Are you sure you want to change the base?
Conversation
見よう見まねで書いたのでおかしなところあったら言ってください. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
諸々レビューしました、諸々お願いします:pray-nya:
type: integer | ||
description: 実行時間制限 | ||
example: 2000 | ||
readonlyFiles: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
説明不足でごめん: ファイルパスは環境変数として渡すからenvsがあるなら消してしまってもいいかも
type: string | ||
description: 環境 | ||
example: env | ||
connectionTimeLimit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
connection/execution time limitはjudge-control app側設定なので、代わりにback-judgeで定義されているoptional info(tl, ml, langみたいなやつ)を渡してほしいです
servers: | ||
- url: https://api.server.test/v1 | ||
paths: | ||
"/result": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/executeのresponseとして返した方が楽かも mustではないけど
description: Bad Request | ||
security: | ||
- bearerAuth: [] | ||
"/container": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これはawsがやってくれるという話になっていたはずだからzoiくんに確認をとってほしいです
issue
close #193
チェックリスト(nix)