Implement an all-errors-in-once feature for multiple checks

[tpierrain]

something like:

var lazyCheck = new LazyCheck();
lazyCheck.That("Batman").Contains("man').And.StartsWith("Bat");
lazyCheck.That(robin.Age).IsGreaterThan(30);
...
lazyCheck.Execute(); // all checks will be executed here.

[tpierrain]

Here is the working code I successfully spiked:

    [Test]
    public void ShouldExecuteAllRegisteredChecksInOnceUpToTheExecuteMethodCall()
    {
        var bienOuBien = true;
        var hero = new Person() { Age = 40, Name = "Thomas", Nationality = Nationality.American };

        var lazyChecks = new LazyChecks();

        lazyChecks.That(bienOuBien).IsTrue();
        lazyChecks.That('c').IsALetter();
        lazyChecks.That(hero.Name).Contains("oma");
        lazyChecks.That(hero).Not.IsInstanceOf<string>();
        lazyChecks.That(hero).IsNotNull().And.IsInstanceOf<Person>();

        lazyChecks.Execute();
    }

When it fails like in the test below:

    [Test]
    public void ShouldRaiseAllFailuresInOneShotAtTheEnd()
    {
        var bienOuBien = true;
        var lazyChecks = new LazyChecks();

        lazyChecks.That(bienOuBien).IsFalse();
        lazyChecks.That('.').IsALetter();

        lazyChecks.Execute();
    }

The exception message looks like:

2 lazy checks failed:
-----------
The checked boolean is true whereas it must be false.
The checked boolean:
    [True]
-----------
The checked char is not a letter.
The checked char:
    ['.']
-----------

The next step for me would be to introduce a new operator As("Check of the name") for anyone to be able to set some metadata that would be output with the error messages. e.g.:

    [Test]
    public void ShouldRaiseAllFailuresInOneShotAtTheEnd()
    {
        var bienOuBien = true;
        var lazyChecks = new LazyChecks();

        for(int counter....)
        {
            lazyChecks.That(bienOuBien).As("first lame test for "+counter).IsFalse();
            lazyChecks.That('.').As("Check the character for "+counter).IsALetter();
        }

        lazyChecks.Execute();
    }

Any interest for that feature anyone?

[miiitch]

+1 for As or something like:

Check.For("vigilante Name").That("Batman....

Michel

-----Message d'origine-----
De : "Thomas PIERRAIN" [email protected]
Envoyé : ‎18/‎11/‎2014 08:23
À : "tpierrain/NFluent" [email protected]
Objet : Re: [NFluent] Implement an all-errors-in-once feature for multiplechecks (#122)

Here is the working code I successfully spiked:
[Test]
public void ShouldExecuteAllRegisteredChecksInOnceUpToTheExecuteMethodCall()
{
var bienOuBien = true;
var hero = new Person() { Age = 40, Name = "Thomas", Nationality = Nationality.American };

    var lazyChecks = new LazyChecks();

    lazyChecks.That(bienOuBien).IsTrue();
    lazyChecks.That('c').IsALetter();
    lazyChecks.That(hero.Name).Contains("oma");
    lazyChecks.That(hero).Not.IsInstanceOf<string>();
    lazyChecks.That(hero).IsNotNull().And.IsInstanceOf<Person>();

    lazyChecks.Execute();
}

When it fails like in the test below:
[Test]
public void ShouldRaiseAllFailuresInOneShotAtTheEnd()
{
var bienOuBien = true;
var lazyChecks = new LazyChecks();

    lazyChecks.That(bienOuBien).IsFalse();
    lazyChecks.That('.').IsALetter();

    lazyChecks.Execute();
}

The exception message looks like:

2 lazy checks failed:

The checked boolean is true whereas it must be false.
The checked boolean:

[True]

The checked char is not a letter.
The checked char:

['.']

The next step for me would be to introduce a new operator As("Check of the name") for anyone to be able to set some metadata that would be output with the error messages. e.g.:
[Test]
public void ShouldRaiseAllFailuresInOneShotAtTheEnd()
{
var bienOuBien = true;
var lazyChecks = new LazyChecks();

    for(int counter....)
    {
        lazyChecks.That(bienOuBien).As("first lame test for "+counter).IsFalse();
        lazyChecks.That('.').As("Check the character for "+counter).IsALetter();
    }

    lazyChecks.Execute();
}

Any interest for that feature anyone?
—
Reply to this email directly or view it on GitHub.=

[dupdob]

I think it's due time to clarify anticipated use cases for the lazy checks.

@miitch: I like your proposed syntax: Check.For("label").That(xxx)

It should easy to add.

[tpierrain]

Thank you @MIIICH , this is brilliant!

@cyrille : I suggest you add an "issue" to draft your notion of "reusable contract" and let people comment and iterate on it.

I'm bringing my laptop again today, so we could work on it together if you are available.

NFluent v2 is coming.... ;-)

[dupdob]

Hi, V2.3 version has been massively refactored and open the door to such an evolution