Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document URL support #12

Open
fonsp opened this issue Sep 2, 2020 · 7 comments
Open

Document URL support #12

fonsp opened this issue Sep 2, 2020 · 7 comments

Comments

@fonsp
Copy link
Contributor

fonsp commented Sep 2, 2020

This package already supports opening URLs by simply passing a URL instead of a path

@tpapp
Copy link
Owner

tpapp commented Sep 2, 2020

I know that xdg-open (Linux) and open (OS X) support URLs, but is this documented for cmd.exe?

@fonsp
Copy link
Contributor Author

fonsp commented Sep 2, 2020

I checked it and it works 👍

@fonsp
Copy link
Contributor Author

fonsp commented Sep 2, 2020

I can't find any documentation (the docs for start don't mention the feature) but there's this:

https://superuser.com/questions/36728/can-i-launch-urls-from-command-line-in-windows

@tpapp
Copy link
Owner

tpapp commented Sep 3, 2020

I understand that empirically it works, but I am reluctant to suggest that the package guarantees it unless it is somehow documented, as we have no CI for Windows.

@fonsp
Copy link
Contributor Author

fonsp commented Sep 3, 2020

Isn't a CI test just another empirical clue?

I tried finding the relevant docs again but I don't know what to search for :(

@tpapp
Copy link
Owner

tpapp commented Sep 3, 2020

For this package, CI and documentation complement each other. Ideally, documented behavior is checked with CI (that happens for Linux), but practically I am OK with either (which is what I do for OS X and Windows at the moment).

@fonsp
Copy link
Contributor Author

fonsp commented Sep 3, 2020

Makes sense, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants