Skip to content
This repository has been archived by the owner on Mar 9, 2021. It is now read-only.

ATTACK_BREATH is unused, possibly by design. #1120

Open
topaz-next-bot opened this issue Dec 17, 2020 · 3 comments
Open

ATTACK_BREATH is unused, possibly by design. #1120

topaz-next-bot opened this issue Dec 17, 2020 · 3 comments
Labels
bug Something isn't working focus

Comments

@topaz-next-bot
Copy link

Issue by mrhappyasthma
Sunday Feb 23, 2020 at 03:55:13
Originally opened as: project-topaz/topaz - Issue 377


There's an ATTACK_BREATH enum value (and similar one in Lua). But it's not used anywhere.

It's possible this may not be needed, since most breath spells are listed as "magical" by most FFXI websites. e.g. "heat breath" is labeled as "fire" + "magical". (https://ffxiclopedia.fandom.com/wiki/Heat_Breath)

Although if it was intended to be used for something, it's not.

https://github.com/DarkstarProject/darkstar/blob/master/src/map/entities/battleentity.h#L244

https://github.com/DarkstarProject/darkstar/blob/master/scripts/globals/status.lua#L2123

@topaz-next-bot topaz-next-bot added bug Something isn't working focus labels Dec 17, 2020
@topaz-next-bot
Copy link
Author

Comment by mrhappyasthma
Sunday Feb 23, 2020 at 03:57:01


I'm in the process of updating the attackType for all blu spells. I'm going to follow the convention of labeling them as MAGICAL for now.

If we decide this is something we want used, I can go through and change the breath spells to BREATH.

(For context: project-topaz/topaz#314)

@topaz-next-bot
Copy link
Author

Comment by mrhappyasthma
Sunday Feb 23, 2020 at 19:18:29


Per discussion with the appropriate stakeholders, Breath spells will be fixed in the future to have proper damage calculations. I'll update my outstanding PR to label the breath spells as such in preparation for that.

@topaz-next-bot
Copy link
Author

Comment by mrhappyasthma
Sunday Feb 23, 2020 at 19:29:45


Issue to fix breath damage calculation appears to be here: project-topaz/topaz#239

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working focus
Projects
None yet
Development

No branches or pull requests

1 participant