Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple approaches for loading cache data from print page #136

Open
FriedrichFroebel opened this issue Feb 25, 2020 · 2 comments
Open

Multiple approaches for loading cache data from print page #136

FriedrichFroebel opened this issue Feb 25, 2020 · 2 comments

Comments

@FriedrichFroebel
Copy link
Collaborator

There currently are two methods which load cache data from the print page: Cache._from_print_page (a class method) and Cache.load_by_guid (a regular method). The first one uses a language-independent approach, while the second one relies on an English page. In the second case there even is a to-do comment to not rely on an English page.

For this reason, we should probably try to reduce the duplicates there and switch to the language-independent approach.

@tomasbedrich
Copy link
Owner

Good idea! The two versions somehow sneaked up into the code over the years.

@FriedrichFroebel
Copy link
Collaborator Author

Proposal: Move the code from _from_print_page to load_by_guid. Then deprecate _from_print_page (it has been marked as internal anyway) and basically redirect to load_by_guid for the deprecation period.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants