-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Beta Release] New SDK Alert - Breaking Changes #198
Comments
The beta changes are now stable, please update your apps to |
Is photos now supported in RN? |
When I select place from
@tolu360 can you please look in to this soon? Why can't we get those fields? |
Hi Malith,
Please read the README, addressComponents are not supported on all methods
provided - they are not supported in getCurrentPlace. This is NOT a bug!!
…On Mon, Jul 29, 2019, 7:24 AM Malith ***@***.***> wrote:
When I select place from openAutocompleteModal, I get the
address_components. But,
it seems like addressComponents not present in getCurrentPlace() response
objects.
"react": "16.8.6",
"react-native": "0.60.4",
"react-native-google-places": "3.1.1"
@tolu360 <https://github.com/tolu360> can you please look in to this soon?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#198?email_source=notifications&email_token=AA53YZQLNMQUYC6WJZHHOX3QB2EJBA5CNFSM4G5COGK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD27WW7I#issuecomment-515861373>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA53YZT5LH3TQGOGHBEPFULQB2EJBANCNFSM4G5COGKQ>
.
|
Thanks for the quick response. Yes it's not a bug, but can I know that is there any plans to support that on the roadmap ? |
No such plans. The underlying Google SDKs do not provide it in current
place requests, no changes here till if and when that also changes.
|
For more context, see the red notice on the Google docs and feel free to track future changes to those. |
Hi Everyone! New SDK has landed with a couple breaking changes for you to be aware of, first off, discard everything you knew about setting up on Android and continue to the beta README
I added securing your keys and working with CI/CD tools to boot - I hope you enjoy this one, a lot of sweat and love went into it.
Cheers,
Tolu
The text was updated successfully, but these errors were encountered: