Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WineWrap failing silently #309

Open
drostev opened this issue Oct 5, 2019 · 2 comments
Open

WineWrap failing silently #309

drostev opened this issue Oct 5, 2019 · 2 comments

Comments

@drostev
Copy link

drostev commented Oct 5, 2019

When trying to install The Witcher 3 through WineWrap, I was left with an empty installation directory. Running GameHub from the terminal let me see that WineWrap was failing due to a missing package (icoutils.)

The closest thing to an error message was a notification that GameHub could not find the game's executable after WineWrap had "finished." Is there some way to detect that WineWrap has exited abnormally and abort the installation?

@neuromancer
Copy link
Contributor

IMHO, either WineWrap should allow the scripts to work without icoutils or GameHub should warn the user before using WineWrap without icoutils installed (as it works with innoextract)

@drostev
Copy link
Author

drostev commented Oct 5, 2019

I also mentioned in #156 that WineWrap's dependencies should be listed as optional deps for the GameHub packages. Warning the user before installation sounds like a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants