You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using a strategy file the general usage is something like:
# Get the options out of the file
wsclean_options = get_options_from_strategy(
strategy=strategy, mode="wsclean", round=current_round
)
# Pass in the options to the wsclean function, note the update_wsclean_options
wsclean_cmds = task_wsclean_imager.map(
in_ms=cal_mss,
wsclean_container=field_options.wsclean_container,
update_wsclean_options=unmapped(wsclean_options),
fits_mask=fits_beam_masks,
)
It might be nice to add a decorator to the task_wsclean_imager function
The problem is that should this be used we would need to either:
1 - ensure that every such function we wrap has a consistent update_options parameter
2 - update the wrapper_options_from_strategy to accept the keyword to update. Something like:
I am playing around with this under the stratdec branch.
Personally, I prefer option 2. I think being explicit here is perhaps better then being sneaky. It also means we can further specify the mode and operations aspects of the keywords.
When using a strategy file the general usage is something like:
It might be nice to add a decorator to the
task_wsclean_imager
functionso that we can do something like
The problem is that should this be used we would need to either:
1 - ensure that every such function we wrap has a consistent
update_options
parameter2 - update the
wrapper_options_from_strategy
to accept the keyword to update. Something like:so that the keyword to update is a necessary parameter to supply when decorating
The text was updated successfully, but these errors were encountered: