Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linting (ESLint) #7

Open
diguifi opened this issue May 13, 2020 · 2 comments
Open

Add linting (ESLint) #7

diguifi opened this issue May 13, 2020 · 2 comments
Labels
good first issue Good for newcomers

Comments

@diguifi
Copy link
Member

diguifi commented May 13, 2020 •
edited
Loading

Add tslint to project and clear out any warnings
@FabriDamazio FabriDamazio added the good first issue Good for newcomers label May 14, 2020
@diguifi diguifi changed the title Add eslint Add tslint May 19, 2020
@diguifi diguifi added this to the 1.1.0 milestone Oct 22, 2020
@diguifi diguifi removed this from the 0.6.0 milestone Nov 7, 2020
@JoelLau
Copy link

JoelLau commented Aug 24, 2021 •
edited
Loading

hasn't tslint been depracated?

@diguifi
Copy link
Member Author

diguifi commented Aug 24, 2021

@JoelLau You're absolutely correct! This old issue is mostly to make us aware that the entire codebase needs some basic linting. I'll fix the title!

@diguifi diguifi changed the title Add tslint Add linting (ESLint) Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@FabriDamazio @JoelLau @diguifi