Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input lables change 0,1 base #483

Open
CarlFK opened this issue Feb 9, 2020 · 1 comment
Open

input lables change 0,1 base #483

CarlFK opened this issue Feb 9, 2020 · 1 comment

Comments

@CarlFK
Copy link
Contributor

CarlFK commented Feb 9, 2020

Some parts of the UI reference the first input port as input0, some input1.
I suspect this is related to adding source VIDEO_IN_PCIE

If we agree that everything is 0 based, then commands do what we want, but the input status messages are off by one. (the output messages are not.)

H2U 22:59:12>video_matrix connect input1 output1
Connecting input2 to output1

H2U 22:57:59>video_matrix connect input0 encoder 
Connecting input1 to encoder

H2U 22:58:13>status 
input0:  0x0 (@4.28 MHz) (disabled)
input1:  0x0 (@0.00 MHz) (capturing)
output0: [email protected] from input2 (underflows: 0)
output1: [email protected] (underflos primary mode:   [email protected]
EDID secondary mode: [email protected]
encoder: 1280x720 @ 25fps from input1 (q: 85)

status calls:

processor_get_source_name(processor_encoder_source),

which calls:

char * processor_get_source_name(int source) {

@micolous
Copy link
Contributor

micolous commented Mar 29, 2020

It looks like this was a regression introduced in 971d1cb, because it changed pattern from "source 2" to "source 0".

Some of our case designs for Opsis call the onboard inputs "1" and "2", but the "internal" naming has always been "0" and "1". We should retain this, and always call it "0" and "1".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants