Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Item price silently fails if there is no Sales Type #320

Open
dalers opened this issue Dec 18, 2024 · 1 comment
Open

Adding Item price silently fails if there is no Sales Type #320

dalers opened this issue Dec 18, 2024 · 1 comment

Comments

@dalers
Copy link
Collaborator

dalers commented Dec 18, 2024

I tried entering a price for an item before creating any sales types to see what would happen. Entering the price silently fails with no price shown afterwards.

image

Error in httpd-error.log

[Wed Dec 18 15:57:18.672829 2024] [php:error] [pid 31098] [client 162.223.103.50:62349] PHP Fatal error:  Uncaught mysqli_sql_exception: Cannot add or update a child row: a foreign key constraint fails (`weberp_scc`.`prices`, CONSTRAINT `prices_ibfk_3` FOREIGN KEY (`typeabbrev`) REFERENCES `salestypes` (`typeabbrev`)) in /usr/local/www/weberp/includes/ConnectDB_mariadb.inc:58\nStack trace:\n#0 /usr/local/www/weberp/includes/ConnectDB_mariadb.inc(58): mysqli_query()\n#1 /usr/local/www/weberp/Prices.php(158): DB_query()\n#2 {main}\n  thrown in /usr/local/www/weberp/includes/ConnectDB_mariadb.inc on line 58, referer: https://weberp.dalescott.net/Prices.php?Item=100-0004
dale@whizzer:/usr/local/www/weberp $
@dalers
Copy link
Collaborator Author

dalers commented Dec 18, 2024

P.S. if we were ranking issues, I would propose P3 or P4 for this one.

I would also propose a rule that a release is not permitted to have any P1 or P2 issues.

From MS Copilot: A common 5-level issue priority list is often used in project management and IT service management to categorize tasks or issues based on their urgency and importance. Here's a typical breakdown:

  1. Critical (P1): These issues require immediate attention as they can cause significant disruption or have a major impact on operations. Examples include system outages or security breaches.
  2. High (P2): Important issues that need to be addressed soon but are not as urgent as critical issues. These might include significant bugs or performance issues that affect many users.
  3. Medium (P3): Issues that are important but not urgent. They should be resolved in a reasonable timeframe but do not require immediate action. Examples include minor bugs or feature requests.
  4. Low (P4): These issues are less important and can be addressed when time permits. They might include cosmetic issues or minor inconveniences.
  5. Very Low (P5): These are the least urgent issues, often involving long-term improvements or very minor problems that do not significantly impact operations

This prioritization helps teams focus on the most critical tasks first, ensuring that resources are allocated efficiently and effectively.

Source: Conversation with Copilot

References:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant