[EPIC] Material 3 drawer

[wmontwe]

The navigation drawer should look and feel consistent with the rest of the K-9 Mail and Thunderbird for Android Material 3 theme.
As the existing drawer is based on MaterialDrawer it has limited Material 3 support and doesn't allow us to easily adapt to the new design. Therefore we will rewrite the navigation drawer from scratch using Jetpack Compose.

Tasks:

• Move current drawer implementation to feature module #8032
• Add feature flag for Material 3 drawer #8103
• Change drawer to allow Compose UI rendering #8104
• Add the drawer account folder list #8118
• Add account top view #8120
• Add the unified folder list section #8121
• Add drawer bottom view #8122
• Add the account selection side rail #8123
• Fix account and folder selection #8142
• Remove LegacyDrawer implementation #8164 once new drawer works as expected

To improve on:

• Improve drawer sync mechanism #8146
• Save scroll position
• Starred and unread count need to be updated instantly
• Folder names should limited to 2 lines and shortened otherwise
• Image loading needs to be implemented (no contact picture) -> needs design first
• Feature could be split into api and implementation module
• Account name should be single line if email and display name are identical
• [Onboarding] Disable Unified Inbox if there's only one account #7556
• Ellipsize folder name in the middle: support expected for compose foundation 1.8
• Show number of unread emails per account #8300

Related bugs:

• Wrong folders listed for account #8137
• Unread and star count are not properly updated for unified folders (old and new implementation)
• Provide Extra Width For Drawer #8204
• App crashes when I tap on "show accounts" in sidebar #8301
• Changing name of mail account does not change the two letters in account chip.  #8381
• Inbox in french too long in left panel #8487
• Crash while configuring the drawer #8548
• New menu forgets its "Hide accounts" setting #8709

[wmontwe]

The existing drawer has a complex setup to communicate account and folder changes between itself, the MessageList, MessageFragment and different entry points (widgets, notifications). To simplify the communication flow we decided to introduce a separate view model to keep track of the currently active account and when needed selected folder. It should be bound to the lifecycle of the MessageList activity and exposed to the navigation drawer as single source of truth -> #8142

This caused a couple of lifecycle issues and the MessageList remains responsible for the account and folder states.

[kewisch]

@marcRDZ You were asking if you could support on any other issues related to the drawer. @wmontwe is working on some of the foundations for future support of account pictures, once he is done with that there would be an opportunity to help on the image picker.

There are a few remaining issues left on this epic, are there any that are interesting to you? We might not have linked all the issues after the fact, so good to check functionality as well.

[marcRDZ]

@kewisch count on it, I'll review the list to check possible candidates to tackle asap

[marcRDZ]

Hi @kewisch,

I'd been reviewing this a little bit and I have some questions...

[...]

To improve on:

• Save scroll position (No idea what does it mean)

• Starred and unread count need to be updated instantly (I guess is the same as second bug below)

• Feature could be split into api and implementation module (May be too much for me to handle at this moment)

Related bugs:

• Unread and star count are not properly updated for unified folders (old and new implementation) (I saw a weird behaviour with badges only updating when switching between accounts but I'm not sure if that's the matter)

So I think some good issues to resolve easily are:

• Folder names should limited to 2 lines and shortened otherwise
• Account name should be single line if email and display name are identical
• Ellipsize folder name in the middle: support expected for compose foundation 1.8
  Should I create new issues for these?

Also I comment on #8548 a possible cause for the crash, Idk if it could have some sense for you but I'll try to review again on some moment

[wmontwe]

Hi @marcRDZ,

please go ahead and you could create the tickets, I'll link them here.

Maybe you could have a look at #8709 too.

[marcRDZ]

Hi @wmontwe

Here we've the issues:

#8738

• Folder names should limited to 2 lines and shortened otherwise
• Ellipsize folder name in the middle: support expected for compose foundation 1.8

#8739

• Account name should be single line if email and display name are identical