Mime-Type is application/octet-stream instead of application/vnd-com.apple.pkpass

[ligi]

Expected behaviour

When opening a mail with attached pkpass file the mime-type with the intent should be application/vnd-com.apple.pkpass as in gmail

Actual behaviour

The mime-type is application/octet-stream for the same mail that opens with application/vnd-com.apple.pkpass in gmail

Steps to reproduce

1. create a mail with attached pkpass file
2. click on the attachment
3. see the mime-type (e.g. with intent-intercept)

Environment

K-9 Mail version: 5.010

Android version: 5.1.1

Account type (IMAP, POP3, WebDAV/Exchange):IMAP

[cketti]

When opening an attachment the MIME type from the email is used. If that type is application/octet-stream we try to find a better one using MimeTypeMap.getMimeTypeFromExtension(). If that also fails we fall back to MimeUtility.MIME_TYPE_BY_EXTENSION_MAP.

We can add support for .pkpass in MIME_TYPE_BY_EXTENSION_MAP. But this is fixing the problem at the wrong end. Try to send emails containing the correct MIME type. Also, try to get .pkpass support into the system's MimeTypeMap.

[ligi]

Unfortunately I am not controlling the sending end - so #1358 is greatly appreciated

[erAck]

Lol, 8 years and still the wrong fix, though I didn't check if the map is even still used, it's legacy now

thunderbird-android/legacy/core/src/main/java/com/fsck/k9/helper/MimeTypeUtil.java

Line 539 in 59e9e6c

{ "pkpass", "application/vnd-com.apple.pkpass" },

It should had been application/vnd.apple.pkpass instead, see https://developer.apple.com/library/archive/documentation/UserExperience/Conceptual/PassKit_PG/DistributingPasses.html
Just because GMail does something it doesn't mean it's correct..

[kewisch]

Fair point, legacy stuff and standards can be tricky to keep track of—though no need to twist the knife. It looks like you know your way around these. If you have some cycles to spare I'd appreciate if you could take a look and see what the best approach would be going forward, e.g. changing the mime type. A new issue with details, or a pull request, would be very welcome!