You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The country_code enum added under #314 is a bespoke list of ISO 3166-1 alpha-3 codes with string conversions to English country names, but a more robust solution would have been to check if any existing Rust crates handle this mapping. Unsurprisingly, some do exist, e.g. https://docs.rs/iso3166-1.
This would require less manual updating as the ISO 3166-1 list (inevitably) changes, although it would give us less control over the representation of politically sensitive (or just overlong/over-formal) country names. I'm also not sure how (if) it would work for defining the database enum.
The text was updated successfully, but these errors were encountered:
The
country_code
enum added under #314 is a bespoke list of ISO 3166-1 alpha-3 codes with string conversions to English country names, but a more robust solution would have been to check if any existing Rust crates handle this mapping. Unsurprisingly, some do exist, e.g. https://docs.rs/iso3166-1.This would require less manual updating as the ISO 3166-1 list (inevitably) changes, although it would give us less control over the representation of politically sensitive (or just overlong/over-formal) country names. I'm also not sure how (if) it would work for defining the database enum.
The text was updated successfully, but these errors were encountered: