Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] PR test fail to .ldc file not found! #1216

Closed
kv2019i opened this issue Jul 8, 2024 · 4 comments · Fixed by #1217
Closed

[BUG] PR test fail to .ldc file not found! #1216

kv2019i opened this issue Jul 8, 2024 · 4 comments · Fixed by #1217
Labels
P1 Blocker bugs or important features

Comments

@kv2019i
Copy link
Contributor

kv2019i commented Jul 8, 2024

Describe the bug
Example PR test fail from today 8th July 2024
https://sof-ci.01.org/sofpr/PR9186/build6326/devicetest/index.html?model=MTLP_RVP_NOCODEC&testcase=check-sof-logger

Failure started to be seen after merging
thesofproject/sof#9261
@kv2019i kv2019i added the P1 Blocker bugs or important features label Jul 8, 2024
@kv2019i
Copy link
Contributor Author

kv2019i commented Jul 8, 2024

sof-test change needed, but logging here as well, so people can find the issue easier when parsing CI logs.

@lyakh lyakh mentioned this issue Jul 8, 2024
Merged
@kv2019i
Copy link
Contributor Author

kv2019i commented Jul 8, 2024

This effectively disabled FW logs now:
https://sof-ci.01.org/sofpr/PR9116/build6350/devicetest/index.html?model=LNLM_SDW_AIOC&testcase=volume-basic-test

kv2019i referenced this issue in kv2019i/sof-test Jul 8, 2024
@kv2019i
case-lib: remove check for log ldc file
d06f275 
Checking for ldc (log dictionary) file existance as a way to
decide whether to enable or disable logging during a test case,
is no longer applicable as SOF supports multiple firmware logging
solutions that do not use an ldc file.

Remove the check as it no longer makes sense.

Link: https://github.com/thesofproject/sof/issues/9286
Signed-off-by: Kai Vehmanen <[email protected]>
@kv2019i kv2019i mentioned this issue Jul 8, 2024
Merged
@marc-hb marc-hb transferred this issue from thesofproject/sof Jul 8, 2024
@marc-hb
Copy link
Collaborator

marc-hb commented Jul 8, 2024

#1215 restored firmware logs for all tests bug check-sof-logger is still failing

cc: @andyross

andyross added a commit to andyross/sof-test that referenced this issue Jul 9, 2024
@andyross
check-sof-logger.sh Predicate LDC search on !zephyr
b09d901 
Zephyr builds don't produce .ldc files anymore, don't look for them
and fail.

Fixes: thesofproject#1216

Signed-off-by: Andy Ross <[email protected]>
@andyross andyross mentioned this issue Jul 9, 2024
Merged
@andyross
Copy link
Contributor

andyross commented Jul 9, 2024

Pushed up #1217 to (hopefully) address the CI problems with sof-test not having been updated to the new build behavior.

@marc-hb marc-hb closed this as completed in 5f25449 Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 Blocker bugs or important features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

check-sof-logger.sh Predicate LDC search on !zephyr andyross/sof-test
3 participants
@andyross @kv2019i @marc-hb