Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks on API Platform documentation routes are reported in the unprotected routes count but not in the unprotected routes list #10

Open
Loiklak opened this issue Aug 31, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@Loiklak
Copy link
Contributor

Loiklak commented Aug 31, 2022

This is confusing because users don't know which route cause problems

-> We should only check if the documentation route is disabled in prod mode, currently it checks in dev mode. But we want to keep the swagger when developing

The two routes :

  • 'api_entrypoint'
  • 'api_doc'

(cf RouteAccessControlJudge)

@Loiklak Loiklak added the bug Something isn't working label Aug 31, 2022
@Loiklak
Copy link
Contributor Author

Loiklak commented Aug 31, 2022

Actually the api_doc route seems to be necessary to use jsonld so we can't enforce it to be disabled : api-platform/core#3937

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant