Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate pre-commit on GitHub #124

Closed
tovrstra opened this issue Jun 14, 2024 · 5 comments
Closed

Activate pre-commit on GitHub #124

tovrstra opened this issue Jun 14, 2024 · 5 comments

Comments

@tovrstra
Copy link
Member

We currently have pre-commit.ci only activated on a selection of repositories. Would you like ModelHamiltonian to be included in that list?

@PaulWAyers We may just activate it for all repositories, but I'm not sure if that is desirable?

@PaulWAyers
Copy link
Member

I seem to recall that there was an issue having it activated for everything, perhaps the data repository was problematic. I think that @RichRick1 or @marco-2023 would remember.

@RichRick1 can at least tell if it should be activated on this one. I am fine having it activated everywhere (as long as it doesn't break things) as I prefer having a universal QC-Devs workflow/environment.

@PaulWAyers
Copy link
Member

Yes, I remembered correctly. pre-commit doesn't work for the atomdb database repository.
theochem/AtomDBdata#8
I think it probably works for other repositories OK.

@tovrstra
Copy link
Member Author

Oh, yes, I remember. I'll take care of it.

@RichRick1
Copy link
Collaborator

@tovrstra we have pre-commit yaml file in the repo. Contributors still need to install pre-commit using pip, but once it's done, everything is working fine

Thanks for taking care of this!

@tovrstra
Copy link
Member Author

tovrstra commented Jul 8, 2024

I've added this repo to the list that will get checked with pre-commit.ci. This will be visible as an extra check in every new pull request and push to the main branch. If it doesn't show up, please, ping me.

@tovrstra tovrstra closed this as completed Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants