Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulator not loading save files unless if its at the beginning of the game. #160

Closed
preston7363 opened this issue Aug 21, 2024 · 8 comments

Comments

@preston7363
Copy link

I logged off of pokemon LeafGreen for the day and saved and downloaded the save. The next day I accidentally load the wrong save files and tried to change it, but when I did, it just told me to make a new playthrough. Only the save at the beginning of the game works. All others don't. Please help me. thanks

@thenick775
Copy link
Owner

thenick775 commented Aug 21, 2024

Curious on your workflow, did you only save in game?

Did you save your file system in the 'File System' modal?

If you downloaded your save, you'll need to upload it in the pre-game actions menu.

@thenick775 thenick775 added the information requested More information is needed from the reporter label Aug 21, 2024
@preston7363
Copy link
Author

Yes I saved ingame and saved the file system aswell. I uploaded it in the pre-game actions aswell but it just asks me to start a new game.

@preston7363
Copy link
Author

Hey! I figured out the problem. Basically, since I had multiple save files with the same name, my computer would automatically add a number to the end of the file name each time I added a file with the same name. For some reason, the emulator can't read the file with the numbers. For example, it would be able to read: "LeafGreen.sav", and not: "LeafGreen (12).sav". Maybe this is a bug you could fix. Thanks!

@thenick775
Copy link
Owner

thenick775 commented Aug 21, 2024

Ahh yes! For mGBA you must have the same file name exactly the same as the ROM name but with .sav for it to be loaded automatically 😎

That's expected behavior at this time, as it's pretty core to how mGBA loads ROM/sav pairs together.

@thenick775
Copy link
Owner

thenick775 commented Aug 21, 2024

I don't know if I have the time to investigate doing something like that now, but since the gbaJS core (when it existed) was able to reconcile separate save names, I might be able to do the same.

If your ROM had the (1) etc. at the end things would have also loaded. This might be something to add when other cores are roped into the mix.

I think for now adding documentation/tour items to cover this would be best since this is pretty core to how mGBA works and is expected behavior at this time 😎

With the settings UI ticket (#151), I might be able to allow you to turn that off, and load a save file with a name of your choosing.

@thenick775 thenick775 removed the information requested More information is needed from the reporter label Aug 21, 2024
@thenick775 thenick775 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2024
@thenick775
Copy link
Owner

One thing to note, if you save in the file system menu item, you don't need to download your save and reupload it.

It will be stored in your browsers indexeddb, ready for you when you run the ROM the next time.

@preston7363
Copy link
Author

Alright thanks!

@thenick775
Copy link
Owner

@preston7363 I've added some tour text covering this topic, see: #161 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants