Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make implementing cancellation possible #4

Open
ForbesLindesay opened this issue Apr 5, 2013 · 3 comments
Open

Make implementing cancellation possible #4

ForbesLindesay opened this issue Apr 5, 2013 · 3 comments

Comments

@ForbesLindesay
Copy link
Member

No description provided.

@buffpojken
Copy link

Any thoughts on this?

As in, I find myself in need of this and might do a stab at implementing it, but what are you looking for in terms of implementation?

EDIT: Clarification

@ForbesLindesay
Copy link
Member Author

The goal here is to track what happens in https://github.com/promises-aplus/cancellation-spec and consider building a prototype of one of the suggestions in there. Unfortunately cancellation (along with progress) have yet to make it into any formal specification for how promises work.

Personally I'm in favor of Cancellation Tokens (promises-aplus/cancellation-spec#8). These work really well in the .net world, and have the added bonus of not requiring any modification to then/promise.

https://github.com/ForbesLindesay/cancellation contains a prototype implementation of the idea, which I would be happy to expand upon/collaborate on.

@edef1c
Copy link
Member

edef1c commented Dec 11, 2014

My preferred approach (and the semantically most sensible approach) to cancellation does not actually require being part of the Promise implementation, so I consider this issue obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants