Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected Icons Turn Black When Window Out of Focus, Thunar 1.8.* #157

Closed
ghost opened this issue Aug 14, 2018 · 14 comments
Closed

Selected Icons Turn Black When Window Out of Focus, Thunar 1.8.* #157

ghost opened this issue Aug 14, 2018 · 14 comments

Comments

@ghost
Copy link

ghost commented Aug 14, 2018

As the title says, the selected icons in Thunar 1.8.0 and 1.8.1 turn black for some reason when another window is in focus.
Doesn't happen with other themes or the original Numix theme, same for all icon sets.

Screenshots

Thunar window in focus:
Thunar in focus

Thunar window out of focus:
Thunar out of focus

@actionless
Copy link
Member

what WM/DE do you use?

@ghost
Copy link
Author

ghost commented Aug 14, 2018

bspwm, it's the same on i3, wmx and twm, with and without compton.

@ghost
Copy link
Author

ghost commented Aug 14, 2018

Some more info:

  • distro: gentoo
  • sassc - 3.4.7
  • librsvg - 2.40.18
  • glib - 2.52.3
  • gdk-pixbuf - 2.36.12
  • gtk+ - 3.22.30

Thunar 1.8.* is using GTK+3.

@ghost
Copy link
Author

ghost commented Aug 14, 2018

Just installed nautilus. Same issue.

Screenshots


@ghost
Copy link
Author

ghost commented Aug 14, 2018

Did some testing and figured out what it is.
The darker I set the textbox background color, the darker the icons get when the window is out of focus.
To the point where if the textbox background is completely black, the icons and thumbnails turn completely invisible.

Screenshots

Focused:

Out of focus:

Focused:

Out of focus:

Focused:

Out of focus:

Focused:

Out of focus:

@actionless
Copy link
Member

that looks like GTK's :backdrop but i thought it's supported only in GNOME and Cinnamon

@ghost
Copy link
Author

ghost commented Aug 14, 2018

Also, it's not just brightness that changes, but color as well.

Screenshots


@actionless
Copy link
Member

actionless commented Aug 14, 2018

yeah, it seems what one of backdrop values is mixed with TXT_BG (which is fine, but mix amount should be much smaller), i am now installing bspwm to try it in Xephyr (backdrop is not working in awesome or openbox)

UPD: it seems what those icons are not :backdrop - related, i'll dig more into it

@ghost
Copy link
Author

ghost commented Aug 14, 2018

Since the issue is related to the theme colors, I just tried some dark themes besides oomox, like Adwaita Dark and Arc Dark and the same thing happens apparently. The icons get darker when the window is out of focus, although it's not as noticeable since those themes are not as dark as the one I'm using.
So I guess it's not an oomox issue then..

@actionless
Copy link
Member

@shimapan-mode i know for sure gtk-3 have some hardcoded widget parts not fully ruleable by themes (for example Inset/Outset/Groove/Ridge frames or some outline properties) so it could be a case

however i can't say for sure because i don't know how to introspect iconview with gtk inspector

@ghost
Copy link
Author

ghost commented Aug 14, 2018

@actionless yeah it's not :backdrop, it's :active, check it

Screenshots



@ghost
Copy link
Author

ghost commented Aug 14, 2018

Well, I suppose I'll just save that css bit in .config/gtk-3.0/gtk.css then.

@actionless
Copy link
Member

actionless commented Aug 14, 2018

thanks for helping to debug this, i've pushed a fix

since you are a gentoo user, mb you'll have a look on a ebuild? #153

@ghost
Copy link
Author

ghost commented Aug 14, 2018

np, I'd love to help with the ebuild, but I don't have experience writing ebuilds, and I've got exams coming up real close so I can't afford to procrastinate any longer..
I'll help out if the issue is still active after a couple of weeks

@ghost ghost closed this as completed Aug 14, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant