Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comments at the end of lines are highlighted incorrectly #10

Open
FranklinYu opened this issue Apr 4, 2023 · 2 comments
Open

comments at the end of lines are highlighted incorrectly #10

FranklinYu opened this issue Apr 4, 2023 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@FranklinYu
Copy link

Example:

# this is a comment
x: 1  # this also is a comment

This is frequently used in the official specification.

@thejustinwalsh thejustinwalsh added bug Something isn't working help wanted Extra attention is needed labels Apr 10, 2023
@thejustinwalsh
Copy link
Owner

Still have not found the time to investigate, accepting PRs 😂

@jumarini
Copy link

I'm starting to work with .textpb files, and proper syntax highlighting is a must! I've added support for inline comments, as vaguely-defined as they may be in the spec. Also fixed up some number format regex errors that made themselves known when comments were added. Thanks for the work on it thus far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants