Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Performance of our use of Redux Tool Kit (RTK) #921

Closed
1fifoto opened this issue Aug 17, 2024 · 6 comments
Closed

Improve Performance of our use of Redux Tool Kit (RTK) #921

1fifoto opened this issue Aug 17, 2024 · 6 comments
Assignees
Milestone

Comments

@1fifoto
Copy link
Collaborator

1fifoto commented Aug 17, 2024

Possibly replace/regress Redux Tool Kit (RDK) to use original Redux.

@1fifoto 1fifoto added this to the ODOP 5.1 milestone Aug 17, 2024
@1fifoto 1fifoto self-assigned this Aug 17, 2024
@1fifoto
Copy link
Collaborator Author

1fifoto commented Aug 17, 2024

Taken from Issue 441

medium priority

Performance concerns: compression spring demo10 is my recommendation for a test case to reproduce the performance problem.

From June 23 3:30pm PST Slack entry:
Performance testing:
A quick review of demo sessions discovered that in compression spring demo10, the transition from page 09 to page 10 of 15 contains a search that runs for 70 iterations.
I set up my two VMs side-by-side. The left side was the branch 441 development environment (v5.0dev). The right side was the master branch development environment (v4.6dev).
I used the stopwatch app of my smartphone to do the timing.
The average page 9 to 10 transition time for branch 441 was roughly 21 seconds. The average page 9 to 10 transition time for the master branch was roughly 1.5 seconds.
If you want to run this test many times and eliminate having to hit "Next" a bunch of times, it would be pretty easy to create a stripped-down version of the demo10 script.
Just a side observation ... many operations (demo page transitions) in branch 441 are perceptibly slower than their equivalents in the master branch. So, my guess is that the root performance issue is pretty low-level and impacts a lot more than just Search. Using a Search that requires a large number of iterations makes for a good test case because it makes the differences easy to see. Also, Search is so fundamental to the app, it provides confidence that we are not wasting time on some rare corner case.
Let me know if you think that I can do more along these lines.

@1fifoto
Copy link
Collaborator Author

1fifoto commented Aug 18, 2024

See #622 & #675 for potential performance improvements separate from RTK issues.

@1fifoto 1fifoto changed the title Improve Performance of our use of Redux Tool Kit (RDK) Improve Performance of our use of Redux Tool Kit (RTK) Sep 28, 2024
@grumpyinca
Copy link
Contributor

grumpyinca commented Oct 13, 2024

Testing results on Branch 921 -createstore
Oct 13, 2024

1 - Account SignIn produces a message in the browser console: "No routes matched location "/undefined" "
This message does not seem to have a negative effect on operation while signed in.

2 - Fixing all independent variables and then invoking Search or Seek does not produce a red warning message pop-up with text similar to "Search cannot continue because there are no free independent variables. Help button provides more information.". Basically, from the user's point of view, nothing happens.

3 - Confirmed spinner not working (this was previously mentioned)

4 - See #925 regarding error in extension spring tooltip image.

@1fifoto
Copy link
Collaborator Author

1fifoto commented Oct 20, 2024

Status:

  • Number 1 above is deep inside of routing and is probably related to how we use Okta.
  • Fixed 2 above.
  • Spinner is still not working in 3 above.
  • Mike working on 4 above.

@1fifoto
Copy link
Collaborator Author

1fifoto commented Oct 27, 2024

Merged into master, closing

@1fifoto 1fifoto closed this as completed Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants