Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify pattern file structure: redundancy in instance dir names and padding #15

Open
vlkl-sap opened this issue Feb 10, 2023 · 2 comments
Assignees
Labels
ACK_OBTAINED issue has been reviewed and confirmed enhancement New feature or request

Comments

@vlkl-sap
Copy link

vlkl-sap commented Feb 10, 2023

Problem statement

Instances currently have the following layout:

102_collection_taint_propagation/2_instance_102_collection_taint_propagation

which creates long, redundant names.

Moreover, directories are currently sorted like this by default:

69_pass_variable_between_java_files
6_callable
70_raw_types

Proposed changes

Consider using one of the following for instances:

102_collection_taint_propagation/instance_002
102_collection_taint_propagation/002
102_collection_taint_propagation/002_further_instnace_detail

In addition consider using padding for filename. While it is possible to use ls -v, consider pading all numbers, i.e., 6 to 006, etc.

@compaluca
Copy link
Contributor

It is a good point.

I would go for the second option: 102_collection_taint_propagation/002

Besides refactoring the testability patterns file structure overall (changing issue title in this respect), this needs to be implemented in the framework as well (see testable-eu/sast-tp-framework#40).

@compaluca compaluca changed the title [Java] file layout: redundancy in instance dir names Simplify pattern file layout: redundancy in instance dir names Mar 2, 2023
@compaluca
Copy link
Contributor

added padding part

@compaluca compaluca changed the title Simplify pattern file layout: redundancy in instance dir names Simplify pattern file structure: redundancy in instance dir names and padding Mar 3, 2023
@compaluca compaluca added ACK_OBTAINED issue has been reviewed and confirmed enhancement New feature or request labels Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACK_OBTAINED issue has been reviewed and confirmed enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants