change: ip_range_services to optional value (#1949) #1989
Conversation
…#1949) As of GKE version 1.29 and Autopilot 1.27, the service ip range is given a default of 34.118.224.0/20 per cluster. Versions earlier than the specified version may be omitted, but will be rejected by the validator.
|
Hi @apeabody , sorry for the sudden mention. |
Hi @0Delta! - Generally the related issue (e.g. #1949) or if implementation specific the PR itself are good options. However this PR is currently marked as |
|
Thanks for the replies @apeabody. |
| @@ -147,7 +147,8 @@ variable "additional_ip_range_pods" { | |||
|
|
|||
| variable "ip_range_services" { | |||
| type = string | |||
| description = "The _name_ of the secondary subnet range to use for services" | |||
| description = "The _name_ of the secondary subnet range to use for services. Omit to use default range." | |||
There was a problem hiding this comment.
Can we clarify the new section to something similar to: If not provided the default 34.118.224.0/20 range will be used.
Thanks @0Delta - Given the scope of the change, we'll need to include full test coverage. This can be done by updating at least one standard cluster and one autopilot cluster example to omit |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
resolve #1949
As of GKE version 1.29 and Autopilot 1.27, the service ip range is given a default of 34.118.224.0/20 per cluster.
Versions earlier than the specified version may be omitted, but will be rejected by the validator.
This change has a big impact, but has not been thoroughly discussed yet.
We hope to merge it after sufficient discussion and making the necessary corrections.