Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If an entity acts both as buyer and bidder, does it have 2 uuids? #49

Open
georgiana-b opened this issue Jan 10, 2018 · 2 comments
Open
Assignees
Labels

Comments

@georgiana-b
Copy link
Member

georgiana-b commented Jan 10, 2018

We know that a given entity can act both as bidder and buyer. Does such an entity appear in the Digiwhist dataset with 2 different UUIDs, one for the bidder and one for the buyer role?

If so querying on Actor.name will yield duplicate results because this entity will appear two times.

If not then our architecture is flawed because inserting a Buyer if a Bidder exists with the same id will result in duplicate key error on Actor.id.

@georgiana-b
Copy link
Member Author

georgiana-b commented Jan 10, 2018

I created the Actor base class for Bidder and Buyer to make actor-centric networks easier to manage.

The rationale was that our users don't think in terms of roles but in terms of entities and we assume that when they filter by entity they want to see it in the network in both roles.

However, the risk of failing imports is too high for this gain so I think we should at least remove the id field from Actor. We could keep the Actor class just as a category to make queries on both roles simultaneously easier.

@georgiana-b georgiana-b mentioned this issue Jan 11, 2018
3 tasks
@georgiana-b
Copy link
Member Author

georgiana-b commented Jan 11, 2018

I ended up removing the Actor class for good for reasons explained in #50 so technically this is no longer a bug.
As for the answer, it is still relevant but I don't have it at the moment so I'll leave this issue open but move it far in the backlog for it will be easy to answer once we have all the data in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant