Don't heartbeat if poller is stopped #1707
Open
+95
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added comment on #1706 mentioning that we don't want to automatically make workflow tasks with local activities start failing on poller stop (due to task timeout because we stop heartbeating), but maybe there is some other issue here with worker stop and local activities. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
ProcessWorkflowTaskwill now stop sending heartbeats if the worker is stopped.Why?
Without this change, workflows with local activities could hang indefinitely, waiting for a local activity to execute even when the local activity worker has already stopped.
Checklist
Closes ProcessWorkflowTask is not stopped on worker.Stop() #1706
How was this tested:
New unit test
No