Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iris/Oculus compatibility #33

Open
3TUSK opened this issue Apr 15, 2023 · 1 comment
Open

Iris/Oculus compatibility #33

3TUSK opened this issue Apr 15, 2023 · 1 comment

Comments

@3TUSK
Copy link
Member

3TUSK commented Apr 15, 2023

There was a report to Iris1 stating that SlideShow (the Fabric fork) does not work well with Iris 1.6.1.

An Iris dev explained that one of the following should happen in order to properly fix it:

  • Implement BlendingStateHolder on our SlideRenderType.
  • Our SlideRenderType extends from CompositeRenderType which Iris make it implement BlendingStateHolder.

Considering that there are forks of Iris ported onto Forge, we might want to address this on our end as well. After all, the odds of someone installing one of Iris forks into TeaCon modpack is not zero.

Footnotes

  1. https://discord.com/channels/774352792659820594/1096796834808209501 ↩
3TUSK added a commit that referenced this issue Jun 19, 2023
@3TUSK
GH-33: SlideRenderType is now a CompositeRenderType
4771a7a
@3TUSK 3TUSK changed the title See if we can make SlideRenderType extends CompositeRenderType instead Iris/Oculus compatibility Jun 28, 2023
@3TUSK
Copy link
Member Author

3TUSK commented Jun 28, 2023 •
edited
Loading

Update:

Oculus has fetched a workaround from Iris upstream which makes the extends CompositeRenderType unnecessary. However the wrong lighting issue still persists.

Without Oculus + shaderpack:

312BDF72-5289-4A65-86C0-EF7D3D1345BE

With Oculus + shaderpack:

6BAD50E8-0967-4890-B488-0AE389E4B572

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@3TUSK