Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packagist claims that version 0.1.8.2 require PHP >= 7.2 when it should be >=8.0 #48

Open
magrigry opened this issue Mar 13, 2023 · 2 comments

Comments

@magrigry
Copy link

image

Running a composer update with the following composer.json will download tcdent/php-restclient:0.1.8.2.

{
	"require": {
		"php": "^7.2",
		"tcdent/php-restclient": "^0.1.7",
    },
}
@magrigry magrigry changed the title Composer claims that version 0.1.8.2 require PHP >= 7.2 when it should be >=8.0 Packagist claims that version 0.1.8.2 require PHP >= 7.2 when it should be >=8.0 Mar 13, 2023
@tcdent
Copy link
Owner

tcdent commented Mar 13, 2023

What problem are you having with PHP7? All tests are passing down to 7.4 on my end.

Trying to keep 7.x compatibility around for the rest of 2023.

Screen Shot 2023-03-13 at 3 47 55 PM

@magrigry
Copy link
Author

magrigry commented Mar 14, 2023

The « mixed » return type does not exist in PHP 7.2

public function current() : mixed {
and cause a fatal error. https://3v4l.org/acJX1#v7.2.34

IMHO It’s fine if support for PHP 7.2 is dropped, but packagist needs to be updated with this so composer won’t install an incompatible version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants