Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

Static endpoint deprecation #138

Open
JavierSegoviaCordoba opened this issue Jul 21, 2018 · 9 comments
Open

Static endpoint deprecation #138

JavierSegoviaCordoba opened this issue Jul 21, 2018 · 9 comments

Comments

@JavierSegoviaCordoba
Copy link

In this post https://discussion.developer.riotgames.com/articles/5719/removal-of-the-lol-static-data-v3-api.html we can see RIOT is going to deprecate this endpoint the next month.

Are you going to implement data dragon to the API?

@k4b4l74
Copy link

k4b4l74 commented Jul 25, 2018

I'm on it, i will commit a first version of this, this week

@JavierSegoviaCordoba
Copy link
Author

I am writing my own solution too, I will finish it today

@k4b4l74
Copy link

k4b4l74 commented Jul 25, 2018

I think i will make a pull request of first version today ;)

@baribarton
Copy link

Are the new endpoints supported yet?

@k4b4l74
Copy link

k4b4l74 commented Sep 20, 2018

I have fixed it, but it stills not merge here , you can check out my branch https://github.com/k4b4l74/riot-api-java

@baribarton
Copy link

Thanks a lot! I did end up doing that and it works perfectly :)

@sergeknystautas
Copy link

Would we be able to merge this into the main project? Would be great to have access to the data dragon endpoints in the same API.

@sergeknystautas
Copy link

I had to add lombok to the pom.xml, add @EqualsAndHashCode to the various classes using Lombok, and delete and disable some unit tests around the old static data endpoints and the incomplete SummonerTest (sync and async), but then it was able to build. I didn't check how far it's lagging the main project, but still would love to add the dragon endpoints.

@Nauschi
Copy link

Nauschi commented Jul 17, 2019

I have fixed it, but it stills not merge here , you can check out my branch https://github.com/k4b4l74/riot-api-java

This works perfectly. Thank you very much!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants