Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce real assert for tests #444

Open
Gerold103 opened this issue Nov 14, 2023 · 0 comments
Open

Introduce real assert for tests #444

Gerold103 opened this issue Nov 14, 2023 · 0 comments
Labels
good first issue Good for newcomers qa

Comments

@Gerold103
Copy link
Collaborator

Lua assert() won't kill the process, it only throws an error. For testing it might be better to have a real assert which would abort the process when fails. We could put it into vshard.util.assert() or something alike. In tests it would be redefined to call C function abort() (in test/instances/storage.lua and router.lua). Then we would more reliably catch all asserts which now might go unnoticed, especially when fail inside background services. By default we would keep it equal to Lua assert().

@Gerold103 Gerold103 added qa good first issue Good for newcomers labels Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers qa
Projects
None yet
Development

No branches or pull requests

1 participant