Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to update options on release (RFC) #46

Open
pnvasanth opened this issue Feb 27, 2021 · 5 comments
Open

Add support to update options on release (RFC) #46

pnvasanth opened this issue Feb 27, 2021 · 5 comments

Comments

@pnvasanth
Copy link
Contributor

pnvasanth commented Feb 27, 2021 •
edited
Loading

Currently we are not supporting the options update on release.

Which is available in Tarantool Queue.

Can we please add the support?
@pnvasanth pnvasanth mentioned this issue Feb 27, 2021
Closed
@akudiyar
Copy link
Contributor

akudiyar commented Mar 1, 2021

fifottl driver in tarantool/queue supports the delay parameter: https://github.com/tarantool/queue/blob/8a8818f387d09eb2ce0d6e455576920681ae3ddf/queue/abstract/driver/fifottl.lua#L298
I think adding the same option is a good idea. The implementation may also be borrowed from there.

@pnvasanth
Copy link
Contributor Author

@akudiyar it's sounds good to me.

@rybakit
Copy link

rybakit commented Mar 1, 2021

Also, please consider updating other options besides ttl and delay, see tarantool/queue#125.

@akudiyar
Copy link
Contributor

akudiyar commented Mar 5, 2021

@pnvasanth Feel free to make a PR with these changes, we'll check and accept it.

@pnvasanth
Copy link
Contributor Author

@akudiyar Sure, We need to fix #44 to support options. I will create a PR for both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pnvasanth @rybakit @akudiyar