Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of get_repository_root() #22

Open
KevinGDialpad opened this issue Jun 17, 2022 · 0 comments
Open

Get rid of get_repository_root() #22

KevinGDialpad opened this issue Jun 17, 2022 · 0 comments
Labels
refactor Making future life better

Comments

@KevinGDialpad
Copy link
Contributor

This has returned an empty string since the script stopped running inside a git repo (see #2).

I'm pretty sure that's what creates this error in the output:

fatal: unsafe repository ('/github/workspace' is owned by someone else)
To add an exception for this directory, call:
	git config --global --add safe.directory /github/workspace

The problem is that the tests mock its return value. I'm not sure how much effort it would be to fix them.

@KevinGDialpad KevinGDialpad added the refactor Making future life better label Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Making future life better
Development

No branches or pull requests

1 participant