Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duration formatting rounds up to 1 ms #585

Open
mpfaff opened this issue Mar 20, 2024 · 4 comments
Open

Duration formatting rounds up to 1 ms #585

mpfaff opened this issue Mar 20, 2024 · 4 comments

Comments

@mpfaff
Copy link

mpfaff commented Mar 20, 2024

Average request time seems unaffected, but minimum request time, (probably) maximum request time, and all response time metrics appear to round up to 1 ms.

@mpfaff
Copy link
Author

mpfaff commented Mar 20, 2024

Would you consider using a smaller unit? I think microseconds would still allow Goose to track requests for any reasonable amount of time.

@jeremyandrews
Copy link
Member

I'd welcome a PR to make goose more granular! We'd need to do some testing to confirm it doesn't cause any regressions in functionality or performance, and update all the documentation. But it seems an excellent step forward.

@flyingmutant
Copy link

Did you consider using HdrHistogram? Looks like it should improve both the accuracy and performance, and take care of the coordinated omission code as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants